Fix a null pointer dereference bug in function parse_msg #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In function
field2json
, ifrepeated = false
, the NULL value ofjson
is returned to the caller.In caller function
parse_msg
, the return value of functionfield2json
is dereferenced without any null value check, causing a null pointer dereference bug.rapidjson::Value* field_json = field2json(msg, field, allocator); root->AddMember(name, *field_json, allocator);