SAK-43826: Rubrics - Support weighted criterions (fix previews) (saka…

…iproject#8323) Co-authored-by: Bryan de Oliveira Brettas <[email protected]>
bals1820 · Jun 30, 2020 · 9079644 · 9079644
1 parent 8d419e6
commit 9079644
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-preview.js b/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-preview.js
@@ -47,7 +47,7 @@ export class SakaiRubricPreview extends RubricsElement {
         token="${this.token}"
         criteria="${JSON.stringify(this.rubric.criterions)}"
         gradeFieldId="${this.gradeFieldId}"
-        ?weighted=${this.rubric.weighted}
+        .weighted=${this.rubric.weighted}
         ></sakai-rubric-criterion-preview>
     `;
   }

diff --git a/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-readonly.js b/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-readonly.js
@@ -49,7 +49,7 @@ export class SakaiRubricReadonly extends RubricsElement {
 
       <div class="collapse-details" role="tabpanel" aria-labelledby="rubric_toggle_${this.rubric.id}" id="collapse_shared_${this.rubric.id}">
         <div class="rubric-details style-scope sakai-rubric">
-          <sakai-rubric-criteria-readonly criteria="${JSON.stringify(this.rubric.criterions)}" ?weighted=${this.rubric.weighted}></sakai-rubric-criteria-readonly>
+          <sakai-rubric-criteria-readonly criteria="${JSON.stringify(this.rubric.criterions)}" .weighted=${this.rubric.weighted}></sakai-rubric-criteria-readonly>
         </div>
       </div>
     `;

diff --git a/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-student.js b/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-student.js
@@ -86,7 +86,7 @@ class SakaiRubricStudent extends RubricsElement {
       ${this.preview || this.forcePreview ? html`
         <sakai-rubric-criterion-preview
           criteria="${JSON.stringify(this.rubric.criterions)}"
-          ?weighted=${this.rubric.weighted}
+          .weighted=${this.rubric.weighted}
         ></sakai-rubric-criterion-preview>
         ` : html`
         <sakai-rubric-criterion-student
@@ -95,7 +95,7 @@ class SakaiRubricStudent extends RubricsElement {
           evaluation-details="${JSON.stringify(this.evaluation.criterionOutcomes)}"
           ?preview="${this.preview}"
           entity-id="${this.entityId}"
-          ?weighted=${this.rubric.weighted}
+          .weighted=${this.rubric.weighted}
         ></sakai-rubric-criterion-student>
       `}
     `;

diff --git a/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric.js b/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric.js
@@ -128,7 +128,7 @@ export class SakaiRubric extends RubricsElement {
               <sakai-rubric-criteria-readonly
                 criteria="${JSON.stringify(this.rubric.criterions)}"
                 token="${this.token}"
-                ?weighted=${this.rubric.weighted}
+                .weighted=${this.rubric.weighted}
               />`
             : html`
               <sakai-rubric-criteria
@@ -139,7 +139,7 @@ export class SakaiRubric extends RubricsElement {
                 @save-weights="${this.handleSaveWeights}"
                 @weight-changed="${this.handleCriterionWeightChange}"
                 @refresh-total-weight="${this.handleRefreshTotalWeight}"
-                ?weighted=${this.rubric.weighted}
+                .weighted=${this.rubric.weighted}
                 total-weight="${this.totalWeight}"
                 ?valid-weight="${this.validWeight}"
               />`