Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom logger structure. Fix #26 #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akdilsiz
Copy link

No description provided.

@bamzi
Copy link
Owner

bamzi commented Dec 11, 2019

There are many logging libraries, the zerolog might be great lib but I’m not comfortable forcing the choice at this stage.

What would a better approach be to introduce better loggings but not explicitly choosing the lib?

@akdilsiz
Copy link
Author

The only reason why I used the zerolog lib was in order for testing. Therefore, if you like we can still use cron.Log interface to write a custom Logger without having to use any other log libraries.

As of right now, I'm currently removing zerolog, and adding a default logger as soon as I am done I will PR.

If you would like I can write the testcode while using multiple different logger libraries. What do you think?

@vgarvardt
Copy link

Almost the same can be achieved by using stdlib logger #22 - it is not structured but allows capturing all the library logs using any implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants