Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade pricefeed module to support cosmos 0.47 #16

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

upgrade pricefeed module to support cosmos 0.47 #16

wants to merge 8 commits into from

Conversation

colmazia
Copy link

@colmazia colmazia commented Nov 10, 2023 •
edited by RogerKSI
Loading

Fixed: Support Cosmos v0.47

Implementation details

  • bump cosmos-sdk version to 0.47.12
  • bump ibc-go version to 7.6.0
  • upgrade consumer module
  • upgrade pricefeed module and its params to support new Cosmos version

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI self-requested a review February 16, 2024 06:50
taobun
taobun requested changes Feb 21, 2024
View reviewed changes
x/pricefeed/types/codec.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
taobun
taobun reviewed Feb 21, 2024
View reviewed changes
tools/tools.go
_ "github.com/golang/protobuf/protoc-gen-go"
_ "github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway"
_ "github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger"
_ "github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need v2?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colmazia what's this file for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is auto generated from ignite to generate go files from proto

@RogerKSI RogerKSI self-requested a review February 27, 2024 15:02
@colmazia colmazia requested a review from taobun February 29, 2024 10:26
taobun
taobun reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@taobun taobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's upgrade go to go 1.22

@colmazia
Copy link
Author

colmazia commented Jul 3, 2024 •
edited
Loading

Let's upgrade go to go 1.22

@taobun

  1. Even upgrade to go 1.22, we still need tools.go, do you still want to upgrade it?
  2. More importantly, this code is no longer compatible with the newer ignite version I think (bc I have upgrade my ignite version and can't run it), I think we might need an update.

@colmazia
Copy link
Author

colmazia commented Jul 3, 2024 •
edited
Loading

We may merge this one first then do upgrade it to support new ignite in the next branch

@colmazia colmazia requested a review from taobun July 5, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerKSI RogerKSI RogerKSI approved these changes

@satawatnack satawatnack Awaiting requested review from satawatnack

@taobun taobun Awaiting requested review from taobun

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colmazia @RogerKSI @taobun