Fix updatedeps (0xPolygonHermez#956)

* Fix updatedeps * update docs * use PAT to create PR * update repo URIs
baris-h · Jul 28, 2022 · e395afb · e395afb
1 parent fcf573f
commit e395afb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/.github/workflows/updatedeps.yml b/.github/workflows/updatedeps.yml
@@ -10,8 +10,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v2
-      with:
-        ssh-key: ${{ secrets.UPDATE_DEPS_SSH_PK }}
     - name: Install Go
       uses: actions/setup-go@v1
       with:
@@ -28,11 +26,12 @@ jobs:
       env:
         DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
         DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
-        UPDATE_DEPS_SSH_PK: ${{ secrets.UPDATE_DEPS_SSH_PK }}
+        GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
       run: make update-external-dependencies
     - name: Create Pull Request
       uses: peter-evans/create-pull-request@v3
       with:
+        token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
         commit-message: update external dependencies
         title: Update external dependencies
         body: Check for new images, test vectors and proto files and update the code to use them.

diff --git a/docs/ci/actions.md b/docs/ci/actions.md
@@ -72,11 +72,10 @@ proposes a PR in case it finds any changes. The code executed can be found in
 the [dependencies package].
 
 Currently we are checking [three types of custom dependencies]:
-* External docker images used in the [docker compose file],
-`hermeznetwork/geth-zkevm-contracts` and `hermeznetwork/zkevm-mock-prover`. For
-each image the code compares the digest existing in the docker compose file with
-the digest returned by docker hub API, if they differ it includes the new one in
-the docker compose file.
+* External docker images used in the [docker compose file]. For each image the
+code compares the digest existing in the docker compose file with the digest
+returned by docker hub API, if they differ it includes the new one in the docker
+compose file.
 * Protocol buffer files from [comms protocol repo]: after checking the files
 for changes the client/server golang code is generated from them.
 * Test vectors from the [test vectors repo].

diff --git a/scripts/cmd/dependencies.go b/scripts/cmd/dependencies.go
@@ -8,16 +8,16 @@ import (
 func updateDeps(ctx *cli.Context) error {
 	cfg := &dependencies.Config{
 		Images: &dependencies.ImagesConfig{
-			Names:          []string{"hermeznetwork/geth-zkevm-contracts", "hermeznetwork/zkevm-mock-prover"},
+			Names:          []string{"hermeznetwork/geth-zkevm-contracts", "hermeznetwork/zkprover-local"},
 			TargetFilePath: "../../../docker-compose.yml",
 		},
 		PB: &dependencies.PBConfig{
 			TargetDirPath: "../../../proto/src",
-			SourceRepo:    "git@github.com:0xPolygonHermez/zkevm-comms-protocol.git",
+			SourceRepo:    "https://github.com/0xPolygonHermez/zkevm-comms-protocol.git",
 		},
 		TV: &dependencies.TVConfig{
 			TargetDirPath: "../../../test/vectors/src",
-			SourceRepo:    "git@github.com:0xPolygonHermez/zkevm-testvectors.git",
+			SourceRepo:    "https://github.com/0xPolygonHermez/zkevm-testvectors.git",
 		},
 	}