Marbles: Fix bug where the loop could jump with deja vu < 0.5

barksten · Jul 3, 2021 · fc88883 · fc88883
1 parent 84f4f67
commit fc88883
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/marbles/random/random_sequence.h b/marbles/random/random_sequence.h
@@ -165,8 +165,9 @@ class RandomSequence {
 
     const float p_sqrt = 2.0f * deja_vu_ - 1.0f;
     const float p = p_sqrt * p_sqrt;
+    float rho = random_stream_->GetFloat();
 
-    if (random_stream_->GetFloat() <= p && deja_vu_ <= 0.5f) {
+    if (rho <= p && deja_vu_ <= 0.5f) {
       // Generate a new value and put it at the end of the loop.
       redo_write_ptr_ = &loop_[loop_write_head_];
       *redo_write_ptr_ = deterministic
@@ -178,7 +179,7 @@ class RandomSequence {
       // Do not generate a new value, just replay the loop or jump randomly.
       // through it.
       redo_write_ptr_ = NULL;
-      if (random_stream_->GetFloat() <= p) {
+      if (rho <= p) {
         step_ = static_cast<int>(
             random_stream_->GetFloat() * static_cast<float>(length_));
       } else {