Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default group for translation #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidporos92
Copy link

refs #133

@barryvdh
Copy link
Owner

barryvdh commented May 5, 2017

THis doesn't do anything but add the default to the config, not actually use it, right?

@davidporos92
Copy link
Author

Yes, only added a default config.

@barryvdh
Copy link
Owner

barryvdh commented May 5, 2017

But why, if it's not used?

@davidporos92
Copy link
Author

As far as I understand the main issue (#133) the translation only worked after they added a group to the config. By adding a default group, the translation will work without setting a group, using the default group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants