Skip to content

Commit

Permalink
Delete rtc::TaskQueue
Browse files Browse the repository at this point in the history
All usage was updated to use TaskQueueBase interface directly bypassing rtc::TaskQueue wrapper

Bug: webrtc:14169
Change-Id: I1808afd363b50448d4014d8d8402fce41b16a3ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341082
Commit-Queue: Danil Chapovalov <[email protected]>
Reviewed-by: Mirko Bonadei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#41834}
  • Loading branch information
DanilChapovalov authored and WebRTC LUCI CQ committed Feb 28, 2024
1 parent bbff58d commit dcc1534
Show file tree
Hide file tree
Showing 20 changed files with 0 additions and 191 deletions.
1 change: 0 additions & 1 deletion api/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,6 @@ if (rtc_include_tests) {
"../rtc_base:gunit_helpers",
"../rtc_base:platform_thread",
"../rtc_base:rtc_event",
"../rtc_base:rtc_task_queue",
"../rtc_base:ssl",
"../rtc_base:task_queue_for_test",
"../rtc_base/containers:flat_set",
Expand Down
1 change: 0 additions & 1 deletion api/task_queue/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ if (rtc_include_tests) {
":pending_task_safety_flag",
"../../rtc_base:logging",
"../../rtc_base:rtc_event",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:task_queue_for_test",
"../../test:test_support",
]
Expand Down
2 changes: 0 additions & 2 deletions call/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ rtc_library("rtp_sender") {
"../rtc_base:race_checker",
"../rtc_base:random",
"../rtc_base:rate_limiter",
"../rtc_base:rtc_task_queue",
"../rtc_base:timeutils",
"../rtc_base/synchronization:mutex",
"../rtc_base/task_utils:repeating_task",
Expand Down Expand Up @@ -326,7 +325,6 @@ rtc_library("call") {
"../rtc_base:macromagic",
"../rtc_base:rate_limiter",
"../rtc_base:rtc_event",
"../rtc_base:rtc_task_queue",
"../rtc_base:safe_minmax",
"../rtc_base:stringutils",
"../rtc_base:threading",
Expand Down
2 changes: 0 additions & 2 deletions call/adaptation/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ rtc_library("resource_adaptation") {
"../../rtc_base:logging",
"../../rtc_base:macromagic",
"../../rtc_base:refcount",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:safe_conversions",
"../../rtc_base:stringutils",
"../../rtc_base/experiments:balanced_degradation_settings",
Expand Down Expand Up @@ -90,7 +89,6 @@ if (rtc_include_tests) {
"../../rtc_base:checks",
"../../rtc_base:gunit_helpers",
"../../rtc_base:rtc_event",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:stringutils",
"../../rtc_base:task_queue_for_test",
"../../rtc_base/synchronization:mutex",
Expand Down
1 change: 0 additions & 1 deletion call/degraded_call.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
#include "call/video_send_stream.h"
#include "rtc_base/copy_on_write_buffer.h"
#include "rtc_base/network/sent_packet.h"
#include "rtc_base/task_queue.h"
#include "system_wrappers/include/clock.h"
#include "video/config/video_encoder_config.h"

Expand Down
1 change: 0 additions & 1 deletion call/rtp_transport_controller_send.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "rtc_base/network_route.h"
#include "rtc_base/race_checker.h"
#include "rtc_base/task_queue.h"
#include "rtc_base/task_utils/repeating_task.h"

namespace webrtc {
Expand Down
1 change: 0 additions & 1 deletion call/rtp_transport_controller_send_interface.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
namespace rtc {
struct SentPacket;
struct NetworkRoute;
class TaskQueue;
} // namespace rtc
namespace webrtc {

Expand Down
1 change: 0 additions & 1 deletion call/rtp_video_sender.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include "modules/video_coding/include/video_codec_interface.h"
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_base/task_queue.h"
#include "rtc_base/trace_event.h"

namespace webrtc {
Expand Down
1 change: 0 additions & 1 deletion common_video/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ rtc_library("common_video") {
"../rtc_base:race_checker",
"../rtc_base:rate_statistics",
"../rtc_base:refcount",
"../rtc_base:rtc_task_queue",
"../rtc_base:safe_minmax",
"../rtc_base:timeutils",
"../rtc_base/synchronization:mutex",
Expand Down
3 changes: 0 additions & 3 deletions media/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ rtc_library("rtc_media_base") {
"../rtc_base:logging",
"../rtc_base:macromagic",
"../rtc_base:network_route",
"../rtc_base:rtc_task_queue",
"../rtc_base:sanitizer",
"../rtc_base:socket",
"../rtc_base:stringutils",
Expand Down Expand Up @@ -716,7 +715,6 @@ if (rtc_include_tests) {
"../rtc_base:macromagic",
"../rtc_base:network_route",
"../rtc_base:rtc_event",
"../rtc_base:rtc_task_queue",
"../rtc_base:stringutils",
"../rtc_base:threading",
"../rtc_base:timeutils",
Expand Down Expand Up @@ -852,7 +850,6 @@ if (rtc_include_tests) {
"../rtc_base:macromagic",
"../rtc_base:rtc_base_tests_utils",
"../rtc_base:rtc_event",
"../rtc_base:rtc_task_queue",
"../rtc_base:safe_conversions",
"../rtc_base:stringutils",
"../rtc_base:threading",
Expand Down
1 change: 0 additions & 1 deletion modules/audio_device/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@ rtc_library("audio_device_impl") {
"../../rtc_base:platform_thread",
"../../rtc_base:random",
"../../rtc_base:rtc_event",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:safe_conversions",
"../../rtc_base:stringutils",
"../../rtc_base:timeutils",
Expand Down
1 change: 0 additions & 1 deletion modules/audio_processing/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,6 @@ if (rtc_include_tests) {
"../../api/audio:audio_frame_api",
"../../api/audio:echo_control",
"../../rtc_base:rtc_base_tests_utils",
"../../rtc_base:rtc_task_queue",
"aec_dump",
"aec_dump:aec_dump_unittests",
]
Expand Down
1 change: 0 additions & 1 deletion modules/pacing/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ rtc_library("pacing") {
"../../rtc_base:logging",
"../../rtc_base:macromagic",
"../../rtc_base:rtc_numerics",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:timeutils",
"../../rtc_base/experiments:field_trial_parser",
"../../rtc_base/synchronization:mutex",
Expand Down
2 changes: 0 additions & 2 deletions pc/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2526,7 +2526,6 @@ if (rtc_include_tests && !build_with_chromium) {
"../modules/audio_processing:api",
"../p2p:p2p_test_utils",
"../p2p:rtc_p2p",
"../rtc_base:rtc_task_queue",
"../rtc_base:safe_conversions",
"../test:audio_codec_mocks",
"../test:test_main",
Expand Down Expand Up @@ -2814,7 +2813,6 @@ if (rtc_include_tests && !build_with_chromium) {
"../rtc_base:logging",
"../rtc_base:macromagic",
"../rtc_base:rtc_certificate_generator",
"../rtc_base:rtc_task_queue",
"../rtc_base:ssl",
"../rtc_base:stringutils",
"../rtc_base:task_queue_for_test",
Expand Down
19 changes: 0 additions & 19 deletions rtc_base/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -643,23 +643,6 @@ rtc_source_set("type_traits") {
sources = [ "type_traits.h" ]
}

rtc_library("rtc_task_queue") {
visibility = [ "*" ]
sources = [
"task_queue.cc",
"task_queue.h",
]
deps = [
":macromagic",
"../api/task_queue",
"system:rtc_export",
]
absl_deps = [
"//third_party/abseil-cpp/absl/functional:any_invocable",
"//third_party/abseil-cpp/absl/memory",
]
}

rtc_source_set("rtc_operations_chain") {
visibility = [ "*" ]
sources = [
Expand Down Expand Up @@ -1049,7 +1032,6 @@ rtc_library("threading") {
":platform_thread_types",
":refcount",
":rtc_event",
":rtc_task_queue",
":socket",
":socket_address",
":socket_server",
Expand Down Expand Up @@ -1954,7 +1936,6 @@ if (rtc_include_tests) {
":rtc_base_tests_utils",
":rtc_event",
":rtc_numerics",
":rtc_task_queue",
":safe_compare",
":safe_minmax",
":sample_counter",
Expand Down
32 changes: 0 additions & 32 deletions rtc_base/task_queue.cc

This file was deleted.

117 changes: 0 additions & 117 deletions rtc_base/task_queue.h

This file was deleted.

1 change: 0 additions & 1 deletion rtc_base/task_utils/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ if (rtc_include_tests) {
deps = [
":repeating_task",
"..:rtc_event",
"..:rtc_task_queue",
"..:task_queue_for_test",
"../../api/task_queue",
"../../api/task_queue/test:mock_task_queue_base",
Expand Down
1 change: 0 additions & 1 deletion rtc_tools/network_tester/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ if (rtc_enable_protobuf) {
"../../rtc_base:logging",
"../../rtc_base:macromagic",
"../../rtc_base:protobuf_utils",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:socket_address",
"../../rtc_base:socket_server",
"../../rtc_base:threading",
Expand Down
2 changes: 0 additions & 2 deletions sdk/android/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,6 @@ if (current_os == "linux" || is_android) {
"../../rtc_base:logging",
"../../rtc_base:race_checker",
"../../rtc_base:refcount",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:safe_conversions",
"../../rtc_base:threading",
"../../rtc_base:timestamp_aligner",
Expand Down Expand Up @@ -801,7 +800,6 @@ if (current_os == "linux" || is_android) {
"../../rtc_base:logging",
"../../rtc_base:refcount",
"../../rtc_base:rtc_certificate_generator",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:safe_conversions",
"../../rtc_base:ssl",
"../../rtc_base:stringutils",
Expand Down

0 comments on commit dcc1534

Please sign in to comment.