Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix weights absorbed #546

Merged
merged 2 commits into from
Sep 1, 2023
Merged

BUG: Fix weights absorbed #546

merged 2 commits into from
Sep 1, 2023

Conversation

bashtage
Copy link
Owner

@bashtage bashtage commented Sep 1, 2023

Fix weights issue in #543
Fix test issue

closes #543

Fix slice when selecting variables to drop
@bashtage bashtage force-pushed the fix-wights-absorbed branch from c70aeb7 to b4a4539 Compare September 1, 2023 10:12
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
linearmodels/panel/model.py 100.00%
linearmodels/tests/panel/test_panel_ols.py 100.00%
linearmodels/tests/system/test_formulas.py 100.00%

📢 Thoughts on this report? Let us know!.

Omit escaped formulas that cannot pass for now
@bashtage bashtage force-pushed the fix-wights-absorbed branch from b4a4539 to 77f164c Compare September 1, 2023 10:48
@bashtage bashtage merged commit 26064e7 into main Sep 1, 2023
20 checks passed
@bashtage bashtage deleted the fix-wights-absorbed branch September 1, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanelOLS : Dropping absorbed variables doesn't work with sample weights
1 participant