Restore full coverage #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…W_MIME_TYPES` It is not entirely clear why this line does not get measured as covered by tests when the `filter` approach is used. The expectation is that this has to do with the fact that the `filter` approach results in an iterator being assigned to `SUPPORTED_TEXT_PLAIN_SHOW_MIME_TYPES` resulting in a `Set`, whereas the list comprehension assigns a `Set` constructed from a Vector`. This is pure speculation, trying to materialize the iterator approach first does not result in the line being covered either.
Codecov Report
@@ Coverage Diff @@
## development #29 +/- ##
================================================
+ Coverage 99.09% 100.00% +0.90%
================================================
Files 4 4
Lines 111 110 -1
================================================
Hits 110 110
+ Misses 1 0 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a list comprehension to cover
SUPPORTED_TEXT_PLAIN_SHOW_MIME_TYPESensures it gets covered by tests.It is not entirely clear why this line does not get measured as covered by tests when the
filterapproach is used. The expectation is that this has to do with the fact that thefilterapproach results in an iterator being assigned toSUPPORTED_TEXT_PLAIN_SHOW_MIME_TYPESresulting in aSet, whereas the list comprehension assigns aSetconstructed from a Vector`. This is pure speculation, trying to materialize the iterator approach first does not result in the line
being covered either.