Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skeleton code for starlark common test suite #45

Merged
merged 1 commit into from
May 28, 2019
Merged

Add skeleton code for starlark common test suite #45

merged 1 commit into from
May 28, 2019

Conversation

Quarz0
Copy link
Contributor

@Quarz0 Quarz0 commented May 21, 2019

@Quarz0 Quarz0 requested a review from laurentlb as a code owner May 21, 2019 20:13
laurentlb
laurentlb approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

laurentlb
laurentlb reviewed May 21, 2019
View reviewed changes
test_suite/WORKSPACE Outdated Show resolved Hide resolved
laurentlb
laurentlb reviewed May 21, 2019
View reviewed changes
test_suite/BUILD Outdated Show resolved Hide resolved
@laurentlb laurentlb merged commit 245aa37 into bazelbuild:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlb laurentlb laurentlb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quarz0 @laurentlb