Add initial fixed playhead implementation #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @chrisn , I hope it's ok I took a stab at implementing this feature. There is still a bug when deactivating the feature during playback, in that case the waveform is not updated properly. I guess that's because this still needs the other changes you mentioned in the issue. However, if you leave the feature enabled, then it works as expected. Though the canvas movement is not very smooth, there a small but noticeable stutter as the waveform is moved instead of the playhead. Is there something that should be done about it? |
TristanCacqueray
force-pushed
the
fixed-playhead
branch
from
be32ae6 to
61c09b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at implementing #350