Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exercise files #5

Open
wants to merge 1 commit into
base: lec4-array-ex
Choose a base branch
from

Conversation

JerGerr
Copy link

@JerGerr JerGerr commented Apr 2, 2019

No description provided.

Copy link
Owner

@bch-fullstack bch-fullstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the following changes before your pull request can be approved:
Ex1:
Line 1:
Array.isArray(input){ should be a function declaration
The correct script should have been
function isArray(input){

Ex2
for now, lets stick to declaring function in the normal way as following
function first(array, n) {... // line 1
instead of as an var
Please use curly brackets to wrap the content of your if statements and use triple equal sign === instead of ==
so if (array === null) { return void 0; } ...

Ex3.
Please also wrap your loop content within curly brackets and beautify your code before committing to fix the indentation

Ex4. Good job. However try to play around with !~pin.indexOf('.') statement, I personally prefer to use pin.indexOf('.') > -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants