Add descriptor support to createmultisig rpc #1171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
+ Coverage 70.41% 70.51% +0.09%
==========================================
Files 174 174
Lines 27515 27535 +20
==========================================
+ Hits 19376 19416 +40
+ Misses 8139 8119 -20
☔ View full report in Codecov by Sentry. |
Vasu-08
changed the title
Vasu-08
force-pushed
the
createmultisig_rpc
branch
3 times, most recently
from
d26e7c6 to
3599c13
Compare
Vasu-08
force-pushed
the
createmultisig_rpc
branch
from
3599c13 to
77be48b
Compare
theanmolsharma
suggested changes
Sep 23, 2023
There was a problem hiding this comment.
Instead of creating a descriptor string and then parsing it and then generating address, do this.
- Use the redeem script generated previously to generate address (based on
outputTypepassed as arg). - Generated final descriptor string to be returned using string interpolation
Rationale: We are already generating the redeem script. Creating a descriptor just performs the same checks as Script.fromMultisig() which is unnecessary.
Comment on lines
+2065
to
+2069
| let outputType = valid.str(2); | ||
|
|
||
| if (outputType === null) { | ||
| outputType = outputTypes.LEGACY; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let outputType = valid.str(2); | |
| if (outputType === null) { | |
| outputType = outputTypes.LEGACY; | |
| } | |
| const outputType = valid.str(2) ?? outputTypes.LEGACY; |
| 'Redeem script exceeds size limit.'); | ||
| } | ||
| const isWitness = outputType !== outputTypes.LEGACY; | ||
| const script = Script.fromMultisig(m, n, keys, false, isWitness); |
There was a problem hiding this comment.
Suggested change
| const script = Script.fromMultisig(m, n, keys, false, isWitness); | |
| const redeemScript = Script.fromMultisig(m, n, keys, false, isWitness); |
Comment on lines
+2106
to
+2108
| const subdesc = MultisigDescriptor.fromString( | ||
| `multi(${m},${keyString})`, this.network, context | ||
| ); |
There was a problem hiding this comment.
I don't like this, but can't think of a better alternative atm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds descriptor support to createmultisig rpc.