Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path: remove redundant accountID from path string #502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pinheadmz
Copy link
Member

@pinheadmz pinheadmz commented Jun 22, 2018

Fixes #484

However, as discussed with @nodar-chkuaselidze in slack, because this string gets written to the db this would break consistency with all keys saved before the change and possibly require a db migration.

This needs testing because it affects the API output, and may break downstream applications.

@nodech
Copy link
Member

nodech commented Jun 22, 2018

String does not get written to the database, account is.
Actually Path is being written.

@pinheadmz
Copy link
Member Author

@nodech
Copy link
Member

nodech commented Jun 22, 2018

That is Path object, not an actual string. :)

@pinheadmz pinheadmz added the logs / errors Better feedback to user or prevent user error label Jan 23, 2019
@braydonf braydonf added the wallet Wallet related label Feb 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #502 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   61.93%   61.94%   +<.01%     
==========================================
  Files         156      156              
  Lines       26093    26085       -8     
==========================================
- Hits        16161    16158       -3     
+ Misses       9932     9927       -5
Impacted Files Coverage Δ
lib/wallet/path.js 72.56% <100%> (ø) ⬆️
lib/wallet/nodeclient.js 80.39% <0%> (-0.38%) ⬇️
lib/wallet/walletdb.js 77.57% <0%> (+0.14%) ⬆️
lib/client/node.js 29.41% <0%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3623d04...de05626. Read the comment docs.

@pinheadmz
Copy link
Member Author

Rebased on master to double check test coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logs / errors Better feedback to user or prevent user error wallet Wallet related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derivation Path of known outputs is incorrect
4 participants