Skip to content

Commit

Permalink
t/gitweb-lib: Don't pass constant to decode_utf8
Browse files Browse the repository at this point in the history
Encode.pm started updating the string to decode in-place when a second
argument is passed in version 2.40.

This causes 'decode_utf8("", Encode::FB_CROAK)' to die with a message
like:

  Modification of a read-only value attempted at .../Encode.pm line 216.

Work around this by passing an empty variable instead of a constant
string.

Signed-off-by: Brian Gernhardt <[email protected]>
Acked-by: Jakub Narebski <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
Benabik authored and gitster committed Oct 20, 2010
1 parent 5b57413 commit 598df7b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion t/gitweb-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ if ! test_have_prereq PERL; then
test_done
fi

perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || {
perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || {
skip_all='skipping gitweb tests, perl version is too old'
test_done
}
Expand Down

0 comments on commit 598df7b

Please sign in to comment.