forked from twitter/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade zinc's sbt dependency to 1.0.0: python portion
This review is based off Stu's unsubmitted previous effort: https://rbcommons.com/s/twitter/r/4064 This review depends on its jvm portion https://rbcommons.com/s/twitter/r/4340 It has everything from rb/4064: * Deprecate the name-hashing flag: see buddy review. * Update zinc parser for new analysis headers. * Pass an explicit -cache-dir for zinc to compile the compiler-bridge into. * Bump implementation version of zinc to account for the analysis format change. * Don't iterate over source files while computing per-target deps. Plus a few other changes: * A target flag `zinc_file_manager` to turn off zinc provided file manager, implementation is similar to `fatal_warnings` * Add a jmh test for the new `zinc_file_manager` target flag. * Fixed `test_zinc_analysis`, regenerated test data. Known issues: * Unreported dependencies from indirect ancestors due to name hashing switch, will have to reconstruct in pants * Unreported dependencies from local anonymous classes sbt/zinc#192 * Performance: incremental compile in some cases shows significant slowdowns (50%-80%), will collect more stats, maybe memory pressure. Will follow up the above issues Testing Done: https://travis-ci.org/peiyuwang/pants/builds/174567118 https://travis-ci.org/pantsbuild/pants/builds/174984898 https://travis-ci.org/pantsbuild/pants/builds/176920777 Bugs closed: 3962, 4042 Reviewed at https://rbcommons.com/s/twitter/r/4342/
- Loading branch information
Showing
18 changed files
with
562 additions
and
282 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
jar_library(name='jmh', | ||
jars=[ | ||
jar(org='org.openjdk.jmh', name='jmh-core', rev='1.12'), | ||
jar(org='org.openjdk.jmh', name='jmh-generator-annprocess', rev='1.12'), | ||
], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.