forked from twitter/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor the new SelectInterpreter and GatherSources tasks. (pantsbui…
…ld#4337) Basically just breaks up the big execute() methods into several helpers. This is for two reasons: - Makes it easier to test invalidation (see below). - Will enable selecting interpreters and gathering sources separately for each target and its deps (for use by the PythonEval task) side-by-side with the current functionality of selecting a single interpreter and creating a single source PEX for the entire closure. This will be implemented in a future change. Note that testing invalidation isn't an idle idea - I noticed a bug in the custom fingerprint strategy that was mixing in the target payload for no good reason. This change fixes that bug and adds a test for it.
- Loading branch information
Showing
4 changed files
with
107 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters