Remove uses of ReleaseOwnership from vulkan backend (flutter#5458)

* Remove uses of ReleaseOwnership from vulkan backend. Flutter no longer needs to release ownership of objects to skia so this change removes the api calls. * Remove Release call from vulkan_device.cc * Update vulkan_application.h * Update vulkan_application.cc * Update vulkan_handle.h
beezit94 · Jun 4, 2018 · 44863aa · 44863aa
1 parent f2992a1
commit 44863aa
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 17 deletions.
diff --git a/vulkan/vulkan_application.cc b/vulkan/vulkan_application.cc
@@ -129,10 +129,6 @@ const VulkanHandle<VkInstance>& VulkanApplication::GetInstance() const {
   return instance_;
 }
 
-void VulkanApplication::ReleaseInstanceOwnership() {
-  instance_.ReleaseOwnership();
-}
-
 std::vector<VkPhysicalDevice> VulkanApplication::GetPhysicalDevices() const {
   if (!IsValid()) {
     return {};

diff --git a/vulkan/vulkan_application.h b/vulkan/vulkan_application.h
@@ -38,8 +38,6 @@ class VulkanApplication {
 
   const VulkanHandle<VkInstance>& GetInstance() const;
 
-  void ReleaseInstanceOwnership();
-
   std::unique_ptr<VulkanDevice> AcquireFirstCompatibleLogicalDevice() const;
 
  private:

diff --git a/vulkan/vulkan_device.cc b/vulkan/vulkan_device.cc
@@ -153,10 +153,6 @@ const VulkanHandle<VkDevice>& VulkanDevice::GetHandle() const {
   return device_;
 }
 
-void VulkanDevice::ReleaseDeviceOwnership() {
-  device_.ReleaseOwnership();
-}
-
 const VulkanHandle<VkPhysicalDevice>& VulkanDevice::GetPhysicalDeviceHandle()
     const {
   return physical_device_;

diff --git a/vulkan/vulkan_device.h b/vulkan/vulkan_device.h
@@ -35,8 +35,6 @@ class VulkanDevice {
 
   uint32_t GetGraphicsQueueIndex() const;
 
-  void ReleaseDeviceOwnership();
-
   FXL_WARN_UNUSED_RESULT
   bool GetSurfaceCapabilities(const VulkanSurface& surface,
                               VkSurfaceCapabilitiesKHR* capabilities) const;

diff --git a/vulkan/vulkan_handle.h b/vulkan/vulkan_handle.h
@@ -50,11 +50,6 @@ class VulkanHandle {
 
   operator Handle() const { return handle_; }
 
-  /// Relinquish responsibility of collecting the underlying handle when this
-  /// object is collected. It is the responsibility of the caller to ensure that
-  /// the lifetime of the handle extends past the lifetime of this object.
-  void ReleaseOwnership() { disposer_ = nullptr; }
-
   void Reset() { DisposeIfNecessary(); }
 
  private: