Skip to content

Commit

Permalink
feat: add test for protection against adding same token twice
Browse files Browse the repository at this point in the history
  • Loading branch information
@matthewlilley
matthewlilley committed Sep 26, 2021
1 parent 87fee89 commit e839926
Showing 1 changed file with 65 additions and 63 deletions.
128 changes: 65 additions & 63 deletions test/MiniChefV2.test.ts
View file
Original file line number Diff line number Diff line change
@@ -1,25 +1,23 @@
import { expect, assert } from "chai";
import { advanceTime, advanceTimeAndBlock, advanceBlockTo, advanceBlock, prepare, deploy, getBigNumber, ADDRESS_ZERO } from "./utilities"
import { ADDRESS_ZERO, advanceBlock, advanceBlockTo, advanceTime, advanceTimeAndBlock, deploy, getBigNumber, prepare } from "./utilities"
import { assert, expect } from "chai"

import { ethers } from "hardhat"

const { BigNumber } = require("ethers")
import {ethers} from "hardhat"

describe("MiniChefV2", function () {
before(async function () {
await prepare(this, ['MiniChefV2', 'SushiToken', 'ERC20Mock', 'RewarderMock', 'RewarderBrokenMock'])
await deploy(this, [
["brokenRewarder", this.RewarderBrokenMock]
])
await prepare(this, ["MiniChefV2", "SushiToken", "ERC20Mock", "RewarderMock", "RewarderBrokenMock"])
await deploy(this, [["brokenRewarder", this.RewarderBrokenMock]])
})

beforeEach(async function () {
await deploy(this, [
["sushi", this.SushiToken],
])
await deploy(this, [["sushi", this.SushiToken]])

await deploy(this,
[["lp", this.ERC20Mock, ["LP Token", "LPT", getBigNumber(10)]],
await deploy(this, [
["lp", this.ERC20Mock, ["LP Token", "LPT", getBigNumber(10)]],
["dummy", this.ERC20Mock, ["Dummy", "DummyT", getBigNumber(10)]],
['chef', this.MiniChefV2, [this.sushi.address]],
["chef", this.MiniChefV2, [this.sushi.address]],
["rlp", this.ERC20Mock, ["LP", "rLPT", getBigNumber(10)]],
["r", this.ERC20Mock, ["Reward", "RewardT", getBigNumber(100000)]],
])
Expand All @@ -34,34 +32,32 @@ describe("MiniChefV2", function () {
describe("PoolLength", function () {
it("PoolLength should execute", async function () {
await this.chef.add(10, this.rlp.address, this.rewarder.address)
expect((await this.chef.poolLength())).to.be.equal(1);
expect(await this.chef.poolLength()).to.be.equal(1)
})
})

describe("Set", function() {
describe("Set", function () {
it("Should emit event LogSetPool", async function () {
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await expect(this.chef.set(0, 10, this.dummy.address, false))
.to.emit(this.chef, "LogSetPool")
.withArgs(0, 10, this.rewarder.address, false)
await expect(this.chef.set(0, 10, this.dummy.address, true))
.to.emit(this.chef, "LogSetPool")
.withArgs(0, 10, this.dummy.address, true)
})
.to.emit(this.chef, "LogSetPool")
.withArgs(0, 10, this.rewarder.address, false)
await expect(this.chef.set(0, 10, this.dummy.address, true)).to.emit(this.chef, "LogSetPool").withArgs(0, 10, this.dummy.address, true)
})

it("Should revert if invalid pool", async function () {
let err;
let err
try {
await this.chef.set(0, 10, this.rewarder.address, false)
} catch (e) {
err = e;
err = e
}

assert.equal(err.toString(), "Error: VM Exception while processing transaction: invalid opcode")
})
})

describe("PendingSushi", function() {
describe("PendingSushi", function () {
it("PendingSushi should equal ExpectedSushi", async function () {
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await this.rlp.approve(this.chef.address, getBigNumber(10))
Expand Down Expand Up @@ -95,49 +91,53 @@ describe("MiniChefV2", function () {
await this.chef.massUpdatePools([0])
//expect('updatePool').to.be.calledOnContract(); //not suported by heardhat
//expect('updatePool').to.be.calledOnContractWith(0); //not suported by heardhat

})

it("Updating invalid pools should fail", async function () {
let err;
let err
try {
await this.chef.massUpdatePools([0, 10000, 100000])
} catch (e) {
err = e;
err = e
}

assert.equal(err.toString(), "Error: VM Exception while processing transaction: invalid opcode")
})
})
})

describe("Add", function () {
it("Should add pool with reward token multiplier", async function () {
await expect(this.chef.add(10, this.rlp.address, this.rewarder.address))
.to.emit(this.chef, "LogPoolAddition")
.withArgs(0, 10, this.rlp.address, this.rewarder.address)
})
.to.emit(this.chef, "LogPoolAddition")
.withArgs(0, 10, this.rlp.address, this.rewarder.address)
})

it("Should revert if pool with same reward token added twice", async function () {
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await expect(this.chef.add(10, this.rlp.address, this.rewarder.address)).to.be.revertedWith("Token already added")
})
})

describe("UpdatePool", function () {
it("Should emit event LogUpdatePool", async function () {
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await advanceBlockTo(1)
await expect(this.chef.updatePool(0))
.to.emit(this.chef, "LogUpdatePool")
.withArgs(0, (await this.chef.poolInfo(0)).lastRewardTime,
(await this.rlp.balanceOf(this.chef.address)),
(await this.chef.poolInfo(0)).accSushiPerShare)
.to.emit(this.chef, "LogUpdatePool")
.withArgs(
0,
(await this.chef.poolInfo(0)).lastRewardTime,
await this.rlp.balanceOf(this.chef.address),
(await this.chef.poolInfo(0)).accSushiPerShare
)
})

it("Should take else path", async function () {
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await advanceBlockTo(1)
await this.chef.batch(
[
this.chef.interface.encodeFunctionData("updatePool", [0]),
this.chef.interface.encodeFunctionData("updatePool", [0]),
],
true
[this.chef.interface.encodeFunctionData("updatePool", [0]), this.chef.interface.encodeFunctionData("updatePool", [0])],
true
)
})
})
Expand All @@ -147,16 +147,16 @@ describe("MiniChefV2", function () {
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await this.rlp.approve(this.chef.address, getBigNumber(10))
await expect(this.chef.deposit(0, getBigNumber(0), this.alice.address))
.to.emit(this.chef, "Deposit")
.withArgs(this.alice.address, 0, 0, this.alice.address)
.to.emit(this.chef, "Deposit")
.withArgs(this.alice.address, 0, 0, this.alice.address)
})

it("Depositing into non-existent pool should fail", async function () {
let err;
let err
try {
await this.chef.deposit(1001, getBigNumber(0), this.alice.address)
} catch (e) {
err = e;
err = e
}

assert.equal(err.toString(), "Error: VM Exception while processing transaction: invalid opcode")
Expand All @@ -167,26 +167,28 @@ describe("MiniChefV2", function () {
it("Withdraw 0 amount", async function () {
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await expect(this.chef.withdraw(0, getBigNumber(0), this.alice.address))
.to.emit(this.chef, "Withdraw")
.withArgs(this.alice.address, 0, 0, this.alice.address)
.to.emit(this.chef, "Withdraw")
.withArgs(this.alice.address, 0, 0, this.alice.address)
})
})

describe("Harvest", function () {
it("Should give back the correct amount of SUSHI and reward", async function () {
await this.r.transfer(this.rewarder.address, getBigNumber(100000))
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await this.rlp.approve(this.chef.address, getBigNumber(10))
expect(await this.chef.lpToken(0)).to.be.equal(this.rlp.address)
let log = await this.chef.deposit(0, getBigNumber(1), this.alice.address)
await advanceTime(86400)
let log2 = await this.chef.withdraw(0, getBigNumber(1), this.alice.address)
let timestamp2 = (await ethers.provider.getBlock(log2.blockNumber)).timestamp
let timestamp = (await ethers.provider.getBlock(log.blockNumber)).timestamp
let expectedSushi = BigNumber.from("10000000000000000").mul(timestamp2 - timestamp)
expect((await this.chef.userInfo(0, this.alice.address)).rewardDebt).to.be.equal("-"+expectedSushi)
await this.chef.harvest(0, this.alice.address)
expect(await this.sushi.balanceOf(this.alice.address)).to.be.equal(await this.r.balanceOf(this.alice.address)).to.be.equal(expectedSushi)
await this.r.transfer(this.rewarder.address, getBigNumber(100000))
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await this.rlp.approve(this.chef.address, getBigNumber(10))
expect(await this.chef.lpToken(0)).to.be.equal(this.rlp.address)
let log = await this.chef.deposit(0, getBigNumber(1), this.alice.address)
await advanceTime(86400)
let log2 = await this.chef.withdraw(0, getBigNumber(1), this.alice.address)
let timestamp2 = (await ethers.provider.getBlock(log2.blockNumber)).timestamp
let timestamp = (await ethers.provider.getBlock(log.blockNumber)).timestamp
let expectedSushi = BigNumber.from("10000000000000000").mul(timestamp2 - timestamp)
expect((await this.chef.userInfo(0, this.alice.address)).rewardDebt).to.be.equal("-" + expectedSushi)
await this.chef.harvest(0, this.alice.address)
expect(await this.sushi.balanceOf(this.alice.address))
.to.be.equal(await this.r.balanceOf(this.alice.address))
.to.be.equal(expectedSushi)
})
it("Harvest with empty user balance", async function () {
await this.chef.add(10, this.rlp.address, this.rewarder.address)
Expand All @@ -203,22 +205,22 @@ describe("MiniChefV2", function () {
let timestamp2 = (await ethers.provider.getBlock(log2.blockNumber)).timestamp
let timestamp = (await ethers.provider.getBlock(log.blockNumber)).timestamp
let expectedSushi = BigNumber.from("10000000000000000").mul(timestamp2 - timestamp)
expect((await this.chef.userInfo(0, this.alice.address)).rewardDebt).to.be.equal("-"+expectedSushi)
expect((await this.chef.userInfo(0, this.alice.address)).rewardDebt).to.be.equal("-" + expectedSushi)
await this.chef.harvest(0, this.alice.address)
expect(await this.sushi.balanceOf(this.alice.address)).to.be.equal(expectedSushi)
})
})

describe("EmergencyWithdraw", function() {
describe("EmergencyWithdraw", function () {
it("Should emit event EmergencyWithdraw", async function () {
await this.r.transfer(this.rewarder.address, getBigNumber(100000))
await this.chef.add(10, this.rlp.address, this.rewarder.address)
await this.rlp.approve(this.chef.address, getBigNumber(10))
await this.chef.deposit(0, getBigNumber(1), this.bob.address)
//await this.chef.emergencyWithdraw(0, this.alice.address)
await expect(this.chef.connect(this.bob).emergencyWithdraw(0, this.bob.address))
.to.emit(this.chef, "EmergencyWithdraw")
.withArgs(this.bob.address, 0, getBigNumber(1), this.bob.address)
.to.emit(this.chef, "EmergencyWithdraw")
.withArgs(this.bob.address, 0, getBigNumber(1), this.bob.address)
})
})
})

0 comments on commit e839926

Please sign in to comment.