Skip to content

Commit

Permalink
Fix mrliptontea#179 full screen mode issues
Browse files Browse the repository at this point in the history
  • Loading branch information
mrliptontea committed Apr 14, 2020
1 parent 6e9e834 commit 8010540
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 6 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,12 @@ If you need to customize styles for [Redmine Backlogs][redmine_backlogs] remembe

Latest (master):

* Fixed #179: full screen mode issues when using redmine_wysiwyg_editor plugin.
* Fixed #177: changed styling for icon-only buttons to resolve weird behavior on hover.
* Added `$icon-width` variable.
* Added margin in some places like after buttons, avatars.
* Changed tooltip background to black.
* Changed top menu styles.

v2.10.2 (2020-04-09):

Expand Down
5 changes: 5 additions & 0 deletions src/sass/components/_icons.scss
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ table.list .buttons > a::before {
}
}

// A empty icon should behave more like icon-only
a.icon:empty {
display: inline-block;
}

.icon-add::before { content: $fa-var-plus-square; }
.icon-edit::before { content: $fa-var-pencil; }
.icon-copy::before { content: $fa-var-copy; }
Expand Down
13 changes: 8 additions & 5 deletions src/sass/components/_top.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,21 @@
// --------------------------------------------------

#top-menu {
$top-menu-padding-vertical: $padding-small-vertical + 1px;
$top-menu-padding-horizontal: $padding-side;
@extend %clearfix;
position: relative;
padding: $padding-small-vertical $padding-side;
box-sizing: border-box;
padding: $top-menu-padding-vertical $top-menu-padding-horizontal;
background: $top-menu-bg;
color: $top-menu-text;
font-size: $font-size-small;

@if $top-menu-collapse {
$toggler-position-v: $padding-small-vertical + 1px;
$toggler-position-v: $top-menu-padding-vertical + 1px;
$toggler-position-h: 1px;

max-height: floor($font-size-base * $font-size-small-unitless * $line-height-base) + $padding-small-vertical;
position: relative;
max-height: floor($font-size-base * $font-size-small-unitless * $line-height-base) + $top-menu-padding-vertical * 2;
padding-bottom: 0;
overflow: hidden;

Expand All @@ -24,7 +27,7 @@

a {
display: inline-block;
margin-bottom: $padding-small-vertical;
margin-bottom: $top-menu-padding-vertical;
white-space: nowrap;
}

Expand Down
2 changes: 1 addition & 1 deletion stylesheets/application.css

Large diffs are not rendered by default.

0 comments on commit 8010540

Please sign in to comment.