Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level-up ShortRead package dependency version #265

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Conversation

joey711
Copy link
Collaborator

@joey711 joey711 commented Jun 20, 2017

This explicitly resolves (through package installation requirements) a difficult to diagnose bug derived from an old version of ShortRead package in Bioconductor. For good measure, Biostrings and data.table were also up-versioned, but the bug-resolving change is the minimum version required for ShortRead.

#263

This explicitly resolves (through package installation requirements) a difficult to diagnose bug derived from an old version of ShortRead package in Bioconductor. For good measure, Biostrings and data.table were also up-versioned, but the bug-resolving change is the minimum version required for ShortRead.

#263
@joey711
Copy link
Collaborator Author

joey711 commented Jun 20, 2017

@benjjneb I went and did the level-up for you, just to avoid this bug / user-confusion in the future. I agree that they should update BioC with R and dada2 version, but it remains possible to create this bug by not-updating BioC and using the latest dada2 version from GitHub; a user behavior we do want to encourage when they're motivated to try the latest features.

@spholmes
Copy link
Collaborator

spholmes commented Jun 20, 2017 via email

@benjjneb
Copy link
Owner

Thanks @joey711

@spholmes Totally agree that BioC is best and recommended installation method. But we now semi-officially support a second installation method (bioconda installation for QIIME2 plugin) which is pulling from the github repository. So it's important to keep ourselves up to date as well!

@benjjneb benjjneb merged commit 59d5e3e into master Jun 20, 2017
@benjjneb benjjneb deleted the Iss263-ShortRead branch May 2, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants