Skip to content

Commit

Permalink
Fix non-exportable library target subclasses (pantsbuild#5533)
Browse files Browse the repository at this point in the history
Change `JaxWsLibrary` and `JavaWireLibrary` to no longer subclass
`ExportableJvmLibrary` because these target types are not actually exportable,
since they represent codegen targets. The current configuration prevents these
targets from being exported.

Fixes pantsbuild#5532
  • Loading branch information
traviscrawford authored and Stu Hood committed Mar 1, 2018
1 parent 4d28172 commit c565695
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,12 @@
from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
unicode_literals, with_statement)

import logging

from pants.backend.jvm.targets.exportable_jvm_library import ExportableJvmLibrary
from pants.backend.jvm.targets.jvm_target import JvmTarget
from pants.base.payload import Payload
from pants.base.payload_field import PrimitiveField


logger = logging.getLogger(__name__)


class JaxWsLibrary(ExportableJvmLibrary):
class JaxWsLibrary(JvmTarget):
"""Generates a Java library from JAX-WS wsdl files."""

def __init__(self,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,14 @@
from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
unicode_literals, with_statement)

import logging

from pants.backend.jvm.targets.exportable_jvm_library import ExportableJvmLibrary
from pants.backend.jvm.targets.jvm_target import JvmTarget
from pants.base.exceptions import TargetDefinitionException
from pants.base.payload import Payload
from pants.base.payload_field import PrimitiveField
from pants.base.validation import assert_list


logger = logging.getLogger(__name__)


class JavaWireLibrary(ExportableJvmLibrary):
class JavaWireLibrary(JvmTarget):
"""A Java library generated from Wire IDL files.
Supports Wire 1.x only.
Expand Down

0 comments on commit c565695

Please sign in to comment.