Skip to content

Commit

Permalink
fix: keep parsing for long commit-messages
Browse files Browse the repository at this point in the history
Previously, we just returned early after too long commit descriptions.
That's suboptimal though, since there may be other errors, such as
a non-alphabetic type or scope, may be present. These are now also
analyzed and display the correct diagnostic.
  • Loading branch information
benpueschel committed Jun 30, 2024
1 parent 0c93db0 commit 9e195ef
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion analysis/header_diagnostics.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ func getHeaderDiagnostics(header string) []lsp.Diagnostic {
Source: "conventional-commit-lsp",
Message: "Commit message must be less than 72 characters",
})
return diagnostics
} else if len(header) > 50 {
diagnostics = append(diagnostics, lsp.Diagnostic{
Severity: 2,
Expand Down

0 comments on commit 9e195ef

Please sign in to comment.