osst: fix read buffer overflow

Check whether index is within bounds before testing the element. Signed-off-by: Roel Kluin <[email protected]> Cc: Willem Riede <[email protected]> Cc: James E.J. Bottomley <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
benxu · Aug 11, 2010 · ef3f7cc · ef3f7cc
1 parent 13bcbc0
commit ef3f7cc
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
@@ -5868,7 +5868,8 @@ static int osst_probe(struct device *dev)
 	}
 
 	/* find a free minor number */
-	for (i=0; os_scsi_tapes[i] && i<osst_max_dev; i++);
+	for (i = 0; i < osst_max_dev && os_scsi_tapes[i]; i++)
+		;
 	if(i >= osst_max_dev) panic ("Scsi_devices corrupt (osst)");
 	dev_num = i;