Bluetooth: Shell: Fix off-by-one in address length validation

Fixes Coverity defect id 248346. Signed-off-by: Aleksander Wasaznik <[email protected]>
benys · Apr 26, 2022 · 77ad017 · 77ad017
1 parent a796927
commit 77ad017
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/subsys/bluetooth/shell/bt.c b/subsys/bluetooth/shell/bt.c
@@ -1048,8 +1048,8 @@ static int cmd_scan_filter_set_addr(const struct shell *sh, size_t argc,
 {
 	const char *addr_arg = argv[1];
 
-	/* Validate length */
-	if (strlen(addr_arg) > sizeof(scan_filter.addr)) {
+	/* Validate length including null terminator. */
+	if (strlen(addr_arg) >= sizeof(scan_filter.addr)) {
 		shell_error(ctx_shell, "Invalid address string: %s\n",
 			    addr_arg);
 		return -ENOEXEC;