lib: posix: add perror() implementation

Add a trivial implementation of `perror()`. Fixes zephyrproject-rtos#46100 Signed-off-by: Christopher Friedt <[email protected]>
benys · Jul 4, 2022 · b391993 · b391993
1 parent e08f84a
commit b391993
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 3 deletions.
diff --git a/doc/services/portability/posix.rst b/doc/services/portability/posix.rst
@@ -290,8 +290,8 @@ This is implemented as part of the minimal C library available in Zephyr.
     strcoll(),
     strcpy(),yes
     strcspn(),
-    strerror(),
-    strerror_r(),
+    strerror(),yes
+    strerror_r(),yes
     strftime(),
     strlen(),yes
     strncat(),yes
@@ -412,7 +412,7 @@ POSIX_DEVICE_IO
     getchar(),
     gets(),
     open(),yes
-    perror(),
+    perror(),yes
     printf(),yes
     putc(),yes
     putchar(),

diff --git a/lib/libc/minimal/include/stdio.h b/lib/libc/minimal/include/stdio.h
@@ -49,6 +49,7 @@ int __printf_like(2, 0) vfprintf(FILE *ZRESTRICT stream,
 				 const char *ZRESTRICT format,
 				 va_list ap);
 
+void perror(const char *s);
 int puts(const char *s);
 
 int fputc(int c, FILE *stream);

diff --git a/lib/posix/CMakeLists.txt b/lib/posix/CMakeLists.txt
@@ -8,6 +8,7 @@ if(CONFIG_POSIX_API)
 endif()
 
 zephyr_library()
+zephyr_library_sources(perror.c)
 zephyr_library_sources(pthread_common.c)
 zephyr_library_sources_ifdef(CONFIG_PTHREAD_IPC pthread_cond.c)
 zephyr_library_sources_ifdef(CONFIG_PTHREAD_IPC pthread_mutex.c)

diff --git a/lib/posix/perror.c b/lib/posix/perror.c
@@ -0,0 +1,18 @@
+/*
+ * Copyright (c) 2022 Meta
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+#include <errno.h>
+#include <stdio.h>
+#include <string.h>
+
+/*
+ * See https://pubs.opengroup.org/onlinepubs/9699919799/functions/perror.html
+ */
+void perror(const char *s)
+{
+	fprintf(stderr, "%s%s%s\n", s == NULL ? "" : s, s == NULL ? "" : ": ",
+		strerror(errno));
+}