ext2: initialize quota info in ext2_xattr_set()

In order to correctly account/limit space usage, should initialize quota info before calling quota related functions. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Chengguang Xu <[email protected]> Reviewed-by: Reviewed-by: Ritesh Harjani <[email protected]> Signed-off-by: Jan Kara <[email protected]>
berg · Jul 9, 2020 · 1197d04 · 1197d04
1 parent cf1013f
commit 1197d04
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
@@ -437,6 +437,9 @@ ext2_xattr_set(struct inode *inode, int name_index, const char *name,
 	name_len = strlen(name);
 	if (name_len > 255 || value_len > sb->s_blocksize)
 		return -ERANGE;
+	error = dquot_initialize(inode);
+	if (error)
+		return error;
 	down_write(&EXT2_I(inode)->xattr_sem);
 	if (EXT2_I(inode)->i_file_acl) {
 		/* The inode already has an extended attribute block. */