Skip to content

Commit

Permalink
ceph: carry snapshot creation time with inodes
Browse files Browse the repository at this point in the history
MDS InodeStat v3 wire structures include a trailing snapshot creation
time member. Unmarshall this and retain it for a future vxattr.

Signed-off-by: David Disseldorp <[email protected]>
Reviewed-by: "Yan, Zheng" <[email protected]>
Signed-off-by: Ilya Dryomov <[email protected]>
  • Loading branch information
ddiss authored and idryomov committed Jul 8, 2019
1 parent e1b8143 commit 193e7b3
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions fs/ceph/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,7 @@ static int fill_inode(struct inode *inode, struct page *locked_page,
dout("%p mode 0%o uid.gid %d.%d\n", inode, inode->i_mode,
from_kuid(&init_user_ns, inode->i_uid),
from_kgid(&init_user_ns, inode->i_gid));
ceph_decode_timespec64(&ci->i_snap_btime, &iinfo->snap_btime);
}

if ((new_version || (new_issued & CEPH_CAP_LINK_SHARED)) &&
Expand Down
10 changes: 10 additions & 0 deletions fs/ceph/mds_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,15 @@ static int parse_reply_info_in(void **p, void *end,
info->dir_pin = -ENODATA;
}

/* snapshot birth time, remains zero for v<=2 */
if (struct_v >= 3) {
ceph_decode_need(p, end, sizeof(info->snap_btime), bad);
ceph_decode_copy(p, &info->snap_btime,
sizeof(info->snap_btime));
} else {
memset(&info->snap_btime, 0, sizeof(info->snap_btime));
}

*p = end;
} else {
if (features & CEPH_FEATURE_MDS_INLINE_DATA) {
Expand Down Expand Up @@ -198,6 +207,7 @@ static int parse_reply_info_in(void **p, void *end,
}

info->dir_pin = -ENODATA;
/* info->snap_btime remains zero */
}
return 0;
bad:
Expand Down
1 change: 1 addition & 0 deletions fs/ceph/mds_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ struct ceph_mds_reply_info_in {
u64 max_bytes;
u64 max_files;
s32 dir_pin;
struct ceph_timespec snap_btime;
};

struct ceph_mds_reply_dir_entry {
Expand Down
1 change: 1 addition & 0 deletions fs/ceph/super.h
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,7 @@ struct ceph_inode_info {
int i_snap_realm_counter; /* snap realm (if caps) */
struct list_head i_snap_realm_item;
struct list_head i_snap_flush_item;
struct timespec64 i_snap_btime;

struct work_struct i_work;
unsigned long i_work_mask;
Expand Down

0 comments on commit 193e7b3

Please sign in to comment.