Skip to content

Commit

Permalink
crypto: prefix header search paths with $(srctree)/
Browse files Browse the repository at this point in the history
Currently, the Kbuild core manipulates header search paths in a crazy
way [1].

To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
the search paths in the srctree. Some Makefiles are already written in
that way, but not all. The goal of this work is to make the notation
consistent, and finally get rid of the gross hacks.

Having whitespaces after -I does not matter since commit 48f6e3c
("kbuild: do not drop -I without parameter").

[1]: https://patchwork.kernel.org/patch/9632347/

Signed-off-by: Masahiro Yamada <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
masahir0y authored and herbertx committed Feb 1, 2019
1 parent f935290 commit 320ca3e
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion drivers/crypto/chelsio/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ccflags-y := -Idrivers/net/ethernet/chelsio/cxgb4
ccflags-y := -I $(srctree)/drivers/net/ethernet/chelsio/cxgb4

obj-$(CONFIG_CRYPTO_DEV_CHELSIO) += chcr.o
chcr-objs := chcr_core.o chcr_algo.o
Expand Down
3 changes: 2 additions & 1 deletion drivers/crypto/chelsio/chtls/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
ccflags-y := -Idrivers/net/ethernet/chelsio/cxgb4 -Idrivers/crypto/chelsio/
ccflags-y := -I $(srctree)/drivers/net/ethernet/chelsio/cxgb4 \
-I $(srctree)/drivers/crypto/chelsio

obj-$(CONFIG_CRYPTO_DEV_CHELSIO_TLS) += chtls.o
chtls-objs := chtls_main.o chtls_cm.o chtls_io.o chtls_hw.o
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_c3xxx/Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ccflags-y := -I$(src)/../qat_common
ccflags-y := -I $(srctree)/$(src)/../qat_common
obj-$(CONFIG_CRYPTO_DEV_QAT_C3XXX) += qat_c3xxx.o
qat_c3xxx-objs := adf_drv.o adf_c3xxx_hw_data.o
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_c3xxxvf/Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ccflags-y := -I$(src)/../qat_common
ccflags-y := -I $(srctree)/$(src)/../qat_common
obj-$(CONFIG_CRYPTO_DEV_QAT_C3XXXVF) += qat_c3xxxvf.o
qat_c3xxxvf-objs := adf_drv.o adf_c3xxxvf_hw_data.o
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_c62x/Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ccflags-y := -I$(src)/../qat_common
ccflags-y := -I $(srctree)/$(src)/../qat_common
obj-$(CONFIG_CRYPTO_DEV_QAT_C62X) += qat_c62x.o
qat_c62x-objs := adf_drv.o adf_c62x_hw_data.o
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_c62xvf/Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ccflags-y := -I$(src)/../qat_common
ccflags-y := -I $(srctree)/$(src)/../qat_common
obj-$(CONFIG_CRYPTO_DEV_QAT_C62XVF) += qat_c62xvf.o
qat_c62xvf-objs := adf_drv.o adf_c62xvf_hw_data.o
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_dh895xcc/Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ccflags-y := -I$(src)/../qat_common
ccflags-y := -I $(srctree)/$(src)/../qat_common
obj-$(CONFIG_CRYPTO_DEV_QAT_DH895xCC) += qat_dh895xcc.o
qat_dh895xcc-objs := adf_drv.o adf_dh895xcc_hw_data.o
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_dh895xccvf/Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ccflags-y := -I$(src)/../qat_common
ccflags-y := -I $(srctree)/$(src)/../qat_common
obj-$(CONFIG_CRYPTO_DEV_QAT_DH895xCCVF) += qat_dh895xccvf.o
qat_dh895xccvf-objs := adf_drv.o adf_dh895xccvf_hw_data.o

0 comments on commit 320ca3e

Please sign in to comment.