Skip to content

Commit

Permalink
bnxt_en: Perform function reset earlier during probe.
Browse files Browse the repository at this point in the history
The firmware call to do function reset is done too late.  It is causing
the rings that have been reserved to be freed.  In NPAR mode, this bug
is causing us to run out of rings.

Fixes: 391be5c ("bnxt_en: Implement new scheme to reserve tx rings.")
Signed-off-by: Michael Chan <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Michael Chan authored and davem330 committed Mar 10, 2017
1 parent 6cbac98 commit 3c2217a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/ethernet/broadcom/bnxt/bnxt.c
Original file line number Diff line number Diff line change
Expand Up @@ -7444,6 +7444,10 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (rc)
goto init_err_pci_clean;

rc = bnxt_hwrm_func_reset(bp);
if (rc)
goto init_err_pci_clean;

bnxt_hwrm_fw_set_time(bp);

dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_SG |
Expand Down Expand Up @@ -7554,10 +7558,6 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (rc)
goto init_err_pci_clean;

rc = bnxt_hwrm_func_reset(bp);
if (rc)
goto init_err_pci_clean;

rc = bnxt_init_int_mode(bp);
if (rc)
goto init_err_pci_clean;
Expand Down

0 comments on commit 3c2217a

Please sign in to comment.