Skip to content

Commit

Permalink
leaking_addresses: skip all /proc/PID except /proc/1
Browse files Browse the repository at this point in the history
When the system is idle it is likely that most files under /proc/PID
will be identical for various processes.  Scanning _all_ the PIDs under
/proc is unnecessary and implies that we are thoroughly scanning /proc.
This is _not_ the case because there may be ways userspace can trigger
creation of /proc files that leak addresses but were not present during
a scan.  For these two reasons we should exclude all PID directories
under /proc except '1/'

Exclude all /proc/PID except /proc/1.

Signed-off-by: Tobin C. Harding <[email protected]>
  • Loading branch information
tcharding committed Apr 6, 2018
1 parent 5e4bac3 commit 472c9e1
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions scripts/leaking_addresses.pl
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@
# Use --debug to output path before parsing, this is useful to find files that
# cause the script to choke.

#
# When the system is idle it is likely that most files under /proc/PID will be
# identical for various processes. Scanning _all_ the PIDs under /proc is
# unnecessary and implies that we are thoroughly scanning /proc. This is _not_
# the case because there may be ways userspace can trigger creation of /proc
# files that leak addresses but were not present during a scan. For these two
# reasons we exclude all PID directories under /proc except '1/'

use warnings;
use strict;
use POSIX;
Expand Down Expand Up @@ -472,6 +480,10 @@ sub walk
my $path = "$pwd/$file";
next if (-l $path);

# skip /proc/PID except /proc/1
next if (($path =~ /^\/proc\/[0-9]+$/) &&
($path !~ /^\/proc\/1$/));

next if (skip($path));

if (-d $path) {
Expand Down

0 comments on commit 472c9e1

Please sign in to comment.