UWB: Return UWB_RSV_ALLOC_NOT_FOUND rather than crashing on NULL dere…

…ference if kzalloc fails Crashing on a null pointer deref is never a nice thing to do. It seems to me that it's better to simply return UWB_RSV_ALLOC_NOT_FOUND if kzalloc() fails in uwb_rsv_find_best_allocation(). Signed-off-by: Jesper Juhl <[email protected]> Acked-by: David Vrabel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
berg · Nov 11, 2010 · 793b623 · 793b623
1 parent 886ccd4
commit 793b623
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/drivers/uwb/allocator.c b/drivers/uwb/allocator.c
@@ -326,7 +326,8 @@ int uwb_rsv_find_best_allocation(struct uwb_rsv *rsv, struct uwb_mas_bm *availab
 	int bit_index;
 
 	ai = kzalloc(sizeof(struct uwb_rsv_alloc_info), GFP_KERNEL);
-
+	if (!ai)
+		return UWB_RSV_ALLOC_NOT_FOUND;
 	ai->min_mas = rsv->min_mas;
 	ai->max_mas = rsv->max_mas;
 	ai->max_interval = rsv->max_interval;