Skip to content

Commit

Permalink
arch/sh: pcie-sh7786: mark unavailable PCI resource as disabled
Browse files Browse the repository at this point in the history
Some PCI MEM resources are marked as IORESOURCE_MEM_32BIT, which means
they are only usable when the SH core runs in 32-bit mode. In 29-bit
mode, such memory regions are not usable.

The existing code for SH7786 properly skips such regions when
configuring the PCIe controller registers. However, because such
regions are still described in the resource array, the
pcibios_scanbus() function in the SuperH pci.c will register them to
the PCI core. Due to this, the PCI core will allocate MEM areas from
this resource, and assign BARs pointing to this area, even though it's
unusable.

In order to prevent this from happening, we mark such regions as
IORESOURCE_DISABLED, which tells the SuperH pci.c pcibios_scanbus()
function to skip them.

Note that we separate marking the region as disabled from skipping it,
because other regions will be marked as disabled in follow-up patches.

Signed-off-by: Thomas Petazzoni <[email protected]>
Signed-off-by: Rich Felker <[email protected]>
  • Loading branch information
tpetazzoni authored and Rich Felker committed Apr 12, 2018
1 parent 3aeb93a commit 7dd7f69
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions arch/sh/drivers/pci/pcie-sh7786.c
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,9 @@ static int __init pcie_init(struct sh7786_pcie_port *port)
* mode, so just skip them entirely.
*/
if ((res->flags & IORESOURCE_MEM_32BIT) && __in_29bit_mode())
res->flags |= IORESOURCE_DISABLED;

if (res->flags & IORESOURCE_DISABLED)
continue;

pci_write_reg(chan, 0x00000000, SH4A_PCIEPTCTLR(win));
Expand Down

0 comments on commit 7dd7f69

Please sign in to comment.