Skip to content

Commit

Permalink
device create: sound: convert device_create_drvdata to device_create
Browse files Browse the repository at this point in the history
Now that device_create() has been audited, rename things back to the
original call to be sane.

Cc: Jaroslav Kysela <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed Oct 16, 2008
1 parent d73a1a6 commit abe9ab8
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 17 deletions.
6 changes: 3 additions & 3 deletions sound/core/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,9 @@ int snd_card_register(struct snd_card *card)
return -EINVAL;
#ifndef CONFIG_SYSFS_DEPRECATED
if (!card->card_dev) {
card->card_dev = device_create_drvdata(sound_class, card->dev,
MKDEV(0, 0), NULL,
"card%i", card->number);
card->card_dev = device_create(sound_class, card->dev,
MKDEV(0, 0), NULL,
"card%i", card->number);
if (IS_ERR(card->card_dev))
card->card_dev = NULL;
}
Expand Down
5 changes: 2 additions & 3 deletions sound/core/sound.c
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,8 @@ int snd_register_device_for_dev(int type, struct snd_card *card, int dev,
return minor;
}
snd_minors[minor] = preg;
preg->dev = device_create_drvdata(sound_class, device,
MKDEV(major, minor),
private_data, "%s", name);
preg->dev = device_create(sound_class, device, MKDEV(major, minor),
private_data, "%s", name);
if (IS_ERR(preg->dev)) {
snd_minors[minor] = NULL;
mutex_unlock(&sound_mutex);
Expand Down
15 changes: 7 additions & 8 deletions sound/oss/soundcard.c
Original file line number Diff line number Diff line change
Expand Up @@ -560,19 +560,18 @@ static int __init oss_init(void)
sound_dmap_flag = (dmabuf > 0 ? 1 : 0);

for (i = 0; i < ARRAY_SIZE(dev_list); i++) {
device_create_drvdata(sound_class, NULL,
MKDEV(SOUND_MAJOR, dev_list[i].minor),
NULL, "%s", dev_list[i].name);
device_create(sound_class, NULL,
MKDEV(SOUND_MAJOR, dev_list[i].minor), NULL,
"%s", dev_list[i].name);

if (!dev_list[i].num)
continue;

for (j = 1; j < *dev_list[i].num; j++)
device_create_drvdata(sound_class, NULL,
MKDEV(SOUND_MAJOR,
dev_list[i].minor + (j*0x10)),
NULL,
"%s%d", dev_list[i].name, j);
device_create(sound_class, NULL,
MKDEV(SOUND_MAJOR,
dev_list[i].minor + (j*0x10)),
NULL, "%s%d", dev_list[i].name, j);
}

if (sound_nblocks >= 1024)
Expand Down
5 changes: 2 additions & 3 deletions sound/sound_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,8 @@ static int sound_insert_unit(struct sound_unit **list, const struct file_operati
else
sprintf(s->name, "sound/%s%d", name, r / SOUND_STEP);

device_create_drvdata(sound_class, dev,
MKDEV(SOUND_MAJOR, s->unit_minor),
NULL, s->name+6);
device_create(sound_class, dev, MKDEV(SOUND_MAJOR, s->unit_minor),
NULL, s->name+6);
return r;

fail:
Expand Down

0 comments on commit abe9ab8

Please sign in to comment.