Skip to content

Commit

Permalink
avoid spurious "may be used uninitialized" warning
Browse files Browse the repository at this point in the history
The timer type simplifications caused a new gcc warning:

  drivers/base/power/domain.c: In function ‘genpd_runtime_suspend’:
  drivers/base/power/domain.c:562:14: warning: ‘time_start’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     elapsed_ns = ktime_to_ns(ktime_sub(ktime_get(), time_start));

despite the actual use of "time_start" not having changed in any way.
It appears that simply changing the type of ktime_t from a union to a
plain scalar type made gcc check the use.

The variable wasn't actually used uninitialized, but gcc apparently
failed to notice that the conditional around the use was exactly the
same as the conditional around the initialization of that variable.

Add an unnecessary initialization just to shut up the compiler.

Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
torvalds committed Dec 25, 2016
1 parent 3ddc76d commit d33d5a6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/base/power/domain.c
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,7 @@ static int genpd_runtime_suspend(struct device *dev)
return -EBUSY;

/* Measure suspend latency. */
time_start = 0;
if (runtime_pm)
time_start = ktime_get();

Expand Down

0 comments on commit d33d5a6

Please sign in to comment.