Skip to content

Commit

Permalink
vfs: tidy up sparse warnings in fs/namei.c
Browse files Browse the repository at this point in the history
While doing the fs/namei.c cleanups, I ran sparse on it, and it pointed
out other large integers and a couple of cases of us using '0' instead
of the proper 'NULL'.

Sparse still doesn't understand some of the conditional locking going
on, but that's no excuse for not fixing up the trivial stuff.

Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
torvalds committed Mar 22, 2012
1 parent 989412b commit f7493e5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ static char *getname_flags(const char __user *filename, int flags, int *empty)

char *getname(const char __user * filename)
{
return getname_flags(filename, 0, 0);
return getname_flags(filename, 0, NULL);
}

#ifdef CONFIG_AUDITSYSCALL
Expand Down Expand Up @@ -1408,7 +1408,7 @@ static inline int can_lookup(struct inode *inode)
*/
static inline long count_masked_bytes(unsigned long mask)
{
return mask*0x0001020304050608 >> 56;
return mask*0x0001020304050608ul >> 56;
}

static inline unsigned int fold_hash(unsigned long hash)
Expand Down Expand Up @@ -1972,7 +1972,7 @@ int user_path_at_empty(int dfd, const char __user *name, unsigned flags,
int user_path_at(int dfd, const char __user *name, unsigned flags,
struct path *path)
{
return user_path_at_empty(dfd, name, flags, path, 0);
return user_path_at_empty(dfd, name, flags, path, NULL);
}

static int user_path_parent(int dfd, const char __user *path,
Expand Down

0 comments on commit f7493e5

Please sign in to comment.