Added a new widget select mechanism.

[tHerrmann]

Also implemented a base editing widget and a hallo wrapper widget to use with this mechanism.

[bergie]

There are several issues with this pull request that prevent merging for now:

• Editor options are not passed properly to the new editing widgets
• Disabling the editor doesn't work
• The code doesn't follow formatting of the rest of Create (there is a mix of 2 and 4 space indentation, no whitespace in assignments, etc)
• The widget naming differs from rest of Create (Create.editWidget vs. Midgard.midgardEditable)
• console.log usage. This isn't available in all browsers

Can you resolve these? Just push the fixes to your fork and this PR will get updated automatically.

[tHerrmann]

Hi Henri,

I have fixed the issue with disabling the editor and improved the code formatting.

Editor options are working for me. Starting create like this changes the floating option in hallo:

         jQuery(document).ready(function() {
             jQuery('body').midgardCreate({
                   editorOptions: {'default': {'floating': false}},
                 url: function() { return 'javascript:false;'; }
             });
         });

How would you name the widgets? Open for suggestions...

Greetings, Tobias

Alkacon Software GmbH - The OpenCms Experts
Tobias Herrmann
An der Wachsfabrik 13
50996 Koeln, DE

Tel: +49 (0)2236 3826-18
Fax: +49 (0)2236 3826-20
Email: [email protected]

http://www.alkacon.com
http://www.opencms.org

Geschäftsführer: Alexander Kandzior, Amtsgericht Köln, HRB 54613

Am 07.01.2012 10:18, schrieb Henri Bergius:

There are several issues with this pull request that prevent merging for now:

• Editor options are not passed properly to the new editing widgets
• Disabling the editor doesn't work
• The code doesn't follow formatting of the rest of Create (there is a mix of 2 and 4 space indentation, no whitespace in assignments, etc)
• The widget naming differs from rest of Create (Create.editWidget vs. Midgard.midgardEditable)

Can you resolve these? Just push the fixes to your fork and this PR will get updated automatically.

---

Reply to this email directly or view it on GitHub:
#26 (comment)