Normalize the filepath so VS's error list has the correct interaction…

…s. (palantir#3145)
berickson1 · Aug 22, 2017 · d63a434 · d63a434
1 parent a66fc77
commit d63a434
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/formatters/msbuildFormatter.ts b/src/formatters/msbuildFormatter.ts
@@ -15,10 +15,11 @@
  * limitations under the License.
  */
 
+import * as path from "path";
+
 import { AbstractFormatter } from "../language/formatter/abstractFormatter";
 import { IFormatterMetadata } from "../language/formatter/formatter";
 import { RuleFailure } from "../language/rule/rule";
-
 import { camelize, dedent } from "../utils";
 
 export class Formatter extends AbstractFormatter {
@@ -36,7 +37,7 @@ export class Formatter extends AbstractFormatter {
 
     public format(failures: RuleFailure[]): string {
         const outputLines = failures.map((failure: RuleFailure) => {
-            const fileName = failure.getFileName();
+            const fileName = path.normalize(failure.getFileName());
             const failureString = failure.getFailure();
             const camelizedRule = camelize(failure.getRuleName());
 

diff --git a/test/formatters/msbuildFormatterTests.ts b/test/formatters/msbuildFormatterTests.ts
@@ -15,6 +15,7 @@
  */
 
 import { assert } from "chai";
+import * as path from "path";
 import * as ts from "typescript";
 
 import { IFormatter, TestUtils } from "../lint";
@@ -55,6 +56,6 @@ describe("MSBuild Formatter", () => {
     });
 
     function getFailureString(file: string, line: number, character: number, reason: string, ruleCamelCase: string, severity: string) {
-        return `${file}(${line},${character}): ${severity} ${ruleCamelCase}: ${reason}\n`;
+        return `${path.normalize(file)}(${line},${character}): ${severity} ${ruleCamelCase}: ${reason}\n`;
     }
 });