[FrameworkBundle] Fix an issue with ContainerAwareEventDispatcher whe…

…n re-entering a scope
berkin · Apr 20, 2011 · cc89d4b · cc89d4b
1 parent 1df8b2e
commit cc89d4b
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 3 deletions.
diff --git a/src/Symfony/Bundle/FrameworkBundle/ContainerAwareEventDispatcher.php b/src/Symfony/Bundle/FrameworkBundle/ContainerAwareEventDispatcher.php
@@ -36,6 +36,12 @@ class ContainerAwareEventDispatcher extends EventDispatcher
      */
     private $listenerIds = array();
 
+    /**
+     * The services registered as listeners
+     * @var array
+     */
+    private $listeners = array();
+
     /**
      * Constructor.
      *
@@ -79,7 +85,12 @@ public function dispatch($eventName, Event $event = null)
     {
         if (isset($this->listenerIds[$eventName])) {
             foreach ($this->listenerIds[$eventName] as $serviceId => $priority) {
-                $this->addListener($eventName, $this->container->get($serviceId), $priority);
+                if (isset($this->listeners[$eventName][$serviceId])) {
+                    $this->removeListener($eventName, $this->listeners[$eventName][$serviceId]);
+                }
+                $listener = $this->container->get($serviceId);
+                $this->listeners[$eventName][$serviceId] = $listener;
+                $this->addListener($eventName, $listener, $priority);
             }
         }
 

diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/ContainerAwareEventDispatcherTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/ContainerAwareEventDispatcherTest.php
@@ -60,17 +60,58 @@ public function testTriggerAListenerServiceOutOfScope()
         $service = $this->getMock('Symfony\Bundle\FrameworkBundle\Tests\Service');
 
         $scope = new Scope('scope');
-
         $container = new Container();
         $container->addScope($scope);
         $container->enterScope('scope');
+
         $container->set('service.listener', $service, 'scope');
 
         $dispatcher = new ContainerAwareEventDispatcher($container);
         $dispatcher->addListenerService('onEvent', 'service.listener');
 
         $container->leaveScope('scope');
-        $dispatcher->dispatch('onEvent');        
+        $dispatcher->dispatch('onEvent');
+    }
+
+    public function testReEnteringAScope()
+    {
+        $event = new Event();
+
+        $service1 = $this->getMock('Symfony\Bundle\FrameworkBundle\Tests\Service');
+
+        $service1
+            ->expects($this->exactly(2))
+            ->method('onEvent')
+            ->with($event)
+        ;
+
+        $scope = new Scope('scope');
+        $container = new Container();
+        $container->addScope($scope);
+        $container->enterScope('scope');
+
+        $container->set('service.listener', $service1, 'scope');
+
+        $dispatcher = new ContainerAwareEventDispatcher($container);
+        $dispatcher->addListenerService('onEvent', 'service.listener');        
+        $dispatcher->dispatch('onEvent', $event);
+
+        $service2 = $this->getMock('Symfony\Bundle\FrameworkBundle\Tests\Service');
+
+        $service2
+            ->expects($this->once())
+            ->method('onEvent')
+            ->with($event)
+        ;
+
+        $container->enterScope('scope');
+        $container->set('service.listener', $service2, 'scope');
+
+        $dispatcher->dispatch('onEvent', $event);
+
+        $container->leaveScope('scope');
+
+        $dispatcher->dispatch('onEvent');
     }
 }