Use persisted value for permalink field if there are unpersisted changes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averell23
reviewed
Jan 15, 2025
Comment on lines
+21
to
+30
| field_name = permalink_options[:with] | ||
|
|
||
| if self.send("#{field_name}_changed?") | ||
| self.send("#{field_name}_was") | ||
| else | ||
| self.send(field_name) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Suggested change
| def persisted_permalink_field | |
| field_name = permalink_options[:with] | |
| if self.send("#{field_name}_changed?") | |
| self.send("#{field_name}_was") | |
| else | |
| self.send(field_name) | |
| end | |
| end | |
| end |
| elsif(!permalink_options.empty?) | ||
| "#{original_to_param}-#{self.send(permalink_options[:with])}" | ||
| "#{original_to_param}-#{persisted_permalink_field}" |
There was a problem hiding this comment.
Apparently there is attribute_in_database which already does this
Suggested change
| "#{original_to_param}-#{persisted_permalink_field}" | |
| "#{original_to_param}-#{attribute_in_database(permalink_options[:with])}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When saving a record fails due to a validation on a field used for a permalink and you send the user back to a form that is built with a pathhelper using said permalink functionality, the permalink is built with the in memory value instead of the persisted value and throws a routing error
Solution:
Always refer to the persisted value for building the permalink