Add check executables have shebangs (in pre-commit and CI) (home-assi…

…stant#33703) * Add check executables have shebangs (in pre-commit and CI) * Fix file permissions * Adjust Azure Pipelines
bfd1964 · Apr 5, 2020 · d33cf28 · d33cf28
1 parent f89c73d
commit d33cf28
Show file tree

Hide file tree

Showing 22 changed files with 11 additions and 1 deletion.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -45,6 +45,7 @@ repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v2.4.0
     hooks:
+      - id: check-executables-have-shebangs
       - id: check-json
       - id: no-commit-to-branch
         args:

diff --git a/azure-pipelines-ci.yml b/azure-pipelines-ci.yml
@@ -44,6 +44,10 @@ stages:
           . venv/bin/activate
           pip install -r requirements_test.txt -c homeassistant/package_constraints.txt
           pre-commit install-hooks
+    - script: |
+        . venv/bin/activate
+        pre-commit run check-executables-have-shebangs --all-files
+      displayName: 'Run executables check'
     - script: |
         . venv/bin/activate
         pre-commit run codespell --all-files

diff --git a/homeassistant/components/dynalite/__init__.py b/homeassistant/components/dynalite/__init__.py
diff --git a/homeassistant/components/dynalite/bridge.py b/homeassistant/components/dynalite/bridge.py
diff --git a/homeassistant/components/dynalite/config_flow.py b/homeassistant/components/dynalite/config_flow.py
diff --git a/homeassistant/components/dynalite/const.py b/homeassistant/components/dynalite/const.py
diff --git a/homeassistant/components/dynalite/dynalitebase.py b/homeassistant/components/dynalite/dynalitebase.py
diff --git a/homeassistant/components/dynalite/light.py b/homeassistant/components/dynalite/light.py
diff --git a/homeassistant/components/dynalite/manifest.json b/homeassistant/components/dynalite/manifest.json
diff --git a/homeassistant/components/dynalite/switch.py b/homeassistant/components/dynalite/switch.py
diff --git a/homeassistant/components/tankerkoenig/__init__.py b/homeassistant/components/tankerkoenig/__init__.py
diff --git a/homeassistant/components/tankerkoenig/manifest.json b/homeassistant/components/tankerkoenig/manifest.json
diff --git a/homeassistant/components/tankerkoenig/sensor.py b/homeassistant/components/tankerkoenig/sensor.py
diff --git a/script/gen_requirements_all.py b/script/gen_requirements_all.py
@@ -68,7 +68,12 @@
 pycrypto==1000000000.0.0
 """
 
-IGNORE_PRE_COMMIT_HOOK_ID = ("check-json", "no-commit-to-branch", "prettier")
+IGNORE_PRE_COMMIT_HOOK_ID = (
+    "check-executables-have-shebangs",
+    "check-json",
+    "no-commit-to-branch",
+    "prettier",
+)
 
 
 def has_tests(module: str):

diff --git a/tests/components/alexa/test_capabilities.py b/tests/components/alexa/test_capabilities.py
diff --git a/tests/components/dynalite/__init__.py b/tests/components/dynalite/__init__.py
diff --git a/tests/components/dynalite/common.py b/tests/components/dynalite/common.py
diff --git a/tests/components/dynalite/test_bridge.py b/tests/components/dynalite/test_bridge.py
diff --git a/tests/components/dynalite/test_config_flow.py b/tests/components/dynalite/test_config_flow.py
diff --git a/tests/components/dynalite/test_init.py b/tests/components/dynalite/test_init.py
diff --git a/tests/components/dynalite/test_light.py b/tests/components/dynalite/test_light.py
diff --git a/tests/components/dynalite/test_switch.py b/tests/components/dynalite/test_switch.py