No namespaced owners on non-namespaces resources

The operator does not need the owner references for anything. Stop setting them on all objects. The background why we do this change is that we were setting some owner references on non-namespaces objects and the owner was namespaced. This is not allowed and can result in strange side effects. Signed-off-by: Roman Mohr <[email protected]>
bg-chun · Jan 3, 2020 · 0bd0b64 · 0bd0b64
1 parent 301898a
commit 0bd0b64
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/pkg/virt-operator/install-strategy/create.go b/pkg/virt-operator/install-strategy/create.go
@@ -104,9 +104,6 @@ func injectOperatorMetadata(kv *v1.KubeVirt, objectMeta *metav1.ObjectMeta, vers
 	objectMeta.Annotations[v1.InstallStrategyVersionAnnotation] = version
 	objectMeta.Annotations[v1.InstallStrategyRegistryAnnotation] = imageRegistry
 	objectMeta.Annotations[v1.InstallStrategyIdentifierAnnotation] = id
-
-	objectMeta.OwnerReferences = []metav1.OwnerReference{*metav1.NewControllerRef(kv, v1.KubeVirtGroupVersionKind)}
-
 }
 
 func generatePatchBytes(ops []string) []byte {

diff --git a/pkg/virt-operator/kubevirt.go b/pkg/virt-operator/kubevirt.go
@@ -295,7 +295,6 @@ func NewKubeVirtController(
 }
 
 func (c *KubeVirtController) getKubeVirtKey() (string, error) {
-	// XXX use owner references instead in general
 	kvs := c.kubeVirtInformer.GetStore().List()
 	if len(kvs) > 1 {
 		log.Log.Errorf("More than one KubeVirt custom resource detected: %v", len(kvs))