Skip to content

Commit

Permalink
test(ngMock): fix Firefox craches on Travis
Browse files Browse the repository at this point in the history
This test keeps causing Firefox 47 (currently used on Travis) to crash and fail
the build. The test passes locally (on Firefox 53). Lowering the loop count from
1000 to 100 seems to fix the issue.
(Note: The crach only affects the mocked implementation of `$interval` and does
not happen locally.)

Closes angular#16040
  • Loading branch information
gkalpak committed Jun 12, 2017
1 parent 420ceb6 commit 53fb909
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions test/ngMock/angular-mocksSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -358,12 +358,12 @@ describe('ngMock', function() {
$interval(function() { counterA++; });
$interval(function() { counterB++; }, 0);

$interval.flush(1000);
expect(counterA).toBe(1000);
expect(counterB).toBe(1000);
$interval.flush(1000);
expect(counterA).toBe(2000);
expect(counterB).toBe(2000);
$interval.flush(100);
expect(counterA).toBe(100);
expect(counterB).toBe(100);
$interval.flush(100);
expect(counterA).toBe(200);
expect(counterB).toBe(200);
}));


Expand Down

0 comments on commit 53fb909

Please sign in to comment.