tested locally

bharathi26 · Apr 22, 2020 · 8b31f5f · 8b31f5f
1 parent 018cc3b
commit 8b31f5f
Show file tree

Hide file tree

Showing 3 changed files with 528 additions and 468 deletions.
diff --git a/packages/rnv/src/configTools/configParser.js b/packages/rnv/src/configTools/configParser.js
@@ -271,7 +271,8 @@ export const versionCheck = async (c) => {
                     c.runtime.rnvVersionRunner
                 )} against project built with rnv v${chalk.red(
                     c.runtime.rnvVersionProject
-                )}. This might result in unexpected behaviour! It is recommended that you run your rnv command with npx prefix: ${recCmd} . or manually update your devDependencies.rnv version in your package.json.`
+                )}. This might result in unexpected behaviour! It is recommended that you run your rnv command with npx prefix: ${recCmd} . or manually update your devDependencies.rnv version in your package.json.`,
+                default: actionNoUpdate
             });
 
             c.runtime.versionCheckCompleted = true;

diff --git a/packages/rnv/src/systemTools/prompt.js b/packages/rnv/src/systemTools/prompt.js
@@ -9,8 +9,10 @@ export const inquirerPrompt = async (params) => {
     const c = Config.getConfig();
     const msg = params.logMessage || params.warningMessage || params.message;
     if (c.program.ci) {
-        if (Array.isArray(params.choices) && typeof params.default !== 'undefined' && typeof params.choices[params.default] !== 'undefined') return { [params.name]: params.choices[params.default] };
-        throw new Error(`--ci option does not allow prompts: ${msg}. Consider adding a default to the question`);
+        if (Array.isArray(params.choices) && typeof params.default !== 'undefined' && params.choices.includes(params.default)) {
+            return Promise.resolve({ [params.name]: params.default });
+        }
+        throw new Error(`--ci option does not allow prompts. Consider adding a default to the ${params.name} question: ${msg}.`);
     }
     if (msg && params.logMessage) logTask(msg, chalk.grey);
     if (msg && params.warningMessage) logWarning(msg);
@@ -19,8 +21,7 @@ export const inquirerPrompt = async (params) => {
     const { type, name } = params;
     if (type === 'confirm' && !name) params.name = 'confirm';
 
-    const result = await inquirer.prompt(params);
-    return result;
+    return inquirer.prompt(params);
 };
 
 export const generateOptions = (