Added tests for Api Credits; more tests in separate PR

bharatthakkar · Aug 21, 2014 · 09772b0 · 09772b0
1 parent e8909d8
commit 09772b0
Show file tree

Hide file tree

Showing 2 changed files with 212 additions and 166 deletions.
diff --git a/SEOstats/Services/Sistrix.php b/SEOstats/Services/Sistrix.php
@@ -88,17 +88,16 @@ public static function getApiCredits() {
       self::guardApiKey();
 
       $dataUrl = sprintf(Config\Services::SISTRIX_API_CREDITS_URL, Config\ApiKeys::SISTRIX_API_ACCESS_KEY);
+      $json = static::_getPage($dataUrl);
 
-      $json = parent::_getPage($dataUrl);
-
-      if(empty($json)) {
+      if(empty($json) || $json == '{}') {
         return parent::noDataDefaultValue();
       }
       $json_decoded = (Helper\Json::decode($json, true));
       return $json_decoded['answer'][0]['credits'][0]['value'];
     }
 
-    protected static function checkApiCredits() {
+    public static function checkApiCredits() {
       return static::getApiCredits() > 0;
     }