Skip to content

Commit

Permalink
gitk: Use --textconv to generate diff text
Browse files Browse the repository at this point in the history
For the most part gitk's focus is on showing history and changes in
a human readable form.  For this reason, it makes sense to generate
the patch text in the diff view using --textconv so that textconv
drivers are used if they are defined.

gitk can also generate patches, but we do not use --textconv because
such patches could not be applied.

Signed-off-by: Johannes Sixt <[email protected]>
Signed-off-by: Paul Mackerras <[email protected]>
  • Loading branch information
j6t authored and paulusmack committed May 16, 2009
1 parent 5e402e5 commit b5cda49
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gitk
Original file line number Diff line number Diff line change
Expand Up @@ -7268,7 +7268,7 @@ proc getblobdiffs {ids} {
global limitdiffs vfilelimit curview
global diffencoding targetline diffnparents

set cmd [diffcmd $ids "-p -C --cc --no-commit-id -U$diffcontext"]
set cmd [diffcmd $ids "-p --textconv -C --cc --no-commit-id -U$diffcontext"]
if {$ignorespace} {
append cmd " -w"
}
Expand Down

0 comments on commit b5cda49

Please sign in to comment.