Skip to content

Commit

Permalink
contrib/examples/git-repack.sh: avoid "test <cond> -a/-o <cond>"
Browse files Browse the repository at this point in the history
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test <cond> && test <cond>" spawning
one extra process by using a single "test <cond> -a <cond>" no
longer exists.

Signed-off-by: Elia Pinto <[email protected]>
Reviewed-by: Matthieu Moy <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
devzero2000 authored and gitster committed Jun 9, 2014
1 parent 57b74cd commit cd4de93
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions contrib/examples/git-repack.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ case ",$all_into_one," in
existing="$existing $e"
fi
done
if test -n "$existing" -a -n "$unpack_unreachable" -a \
-n "$remove_redundant"
if test -n "$existing" && test -n "$unpack_unreachable" && \
test -n "$remove_redundant"
then
# This may have arbitrary user arguments, so we
# have to protect it against whitespace splitting
Expand Down

0 comments on commit cd4de93

Please sign in to comment.