Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused files in facet pages #1838

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Remove unused files in the faceted group of pages.

@jorgemoya jorgemoya requested a review from a team as a code owner January 3, 2025 18:34
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 7:11pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 7:11pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 6, 2025 7:11pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 7:11pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 7:11pm

Copy link

changeset-bot bot commented Jan 3, 2025

⚠️ No Changeset found

Latest commit: e9b8172

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-qmniz6o9b-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 92
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 92
🟢 Best practices 100
🟠 SEO 85

@jorgemoya jorgemoya force-pushed the cleanup-facets-soul branch from 6d29fa5 to e9b8172 Compare January 6, 2025 19:10
@jorgemoya jorgemoya merged commit 21ea621 into soul/main Jan 6, 2025
8 checks passed
@jorgemoya jorgemoya deleted the cleanup-facets-soul branch January 6, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants