-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default ghref for CLI to @bigcommerce/catalyst-core@latest #1846
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
d7a8cac
to
84e440c
Compare
|
.option( | ||
'--gh-ref <ref>', | ||
'Clone a specific ref from the source repository', | ||
'@bigcommerce/catalyst-core@latest', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would've thought this was set to main
before?
Is there a place where main
is hardcoded that we need to change? Or was it just using the GitHub default branch and thus now it would be canary
so by always passing a value for --gh-ref
, even if the default, then the default GitHub branch won't be used implicitly anymore?
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-fc520k4g4-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
Set default ghref to use the latest tag, so that CLI users will not be exposed to canary code by default.
Testing
Ran
create
with no args: