Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default ghref for CLI to @bigcommerce/catalyst-core@latest #1846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bookernath
Copy link
Contributor

@bookernath bookernath commented Jan 3, 2025

What/Why?

Set default ghref to use the latest tag, so that CLI users will not be exposed to canary code by default.

Testing

Ran create with no args:
image

@bookernath bookernath requested a review from a team as a code owner January 3, 2025 23:01
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:07pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:07pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 3, 2025 11:07pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 11:07pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 11:07pm

@bookernath bookernath force-pushed the default-ghref-by-tag branch from d7a8cac to 84e440c Compare January 3, 2025 23:05
Copy link

changeset-bot bot commented Jan 3, 2025

⚠️ No Changeset found

Latest commit: 84e440c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

.option(
'--gh-ref <ref>',
'Clone a specific ref from the source repository',
'@bigcommerce/catalyst-core@latest',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've thought this was set to main before?

Is there a place where main is hardcoded that we need to change? Or was it just using the GitHub default branch and thus now it would be canary so by always passing a value for --gh-ref, even if the default, then the default GitHub branch won't be used implicitly anymore?

Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-fc520k4g4-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants